Fixed #1691 - ZIO Test: Make failure TestAspect
#1741
Conversation
|
|
||
| test.foldCauseM( | ||
| _.untraced match { | ||
| case Cause.Fail(TestFailure.Runtime(Traced(e, _))) if p.run(e).isSuccess => |
There was a problem hiding this comment.
untraced removes all inner Traced so this shouldn't be needed?
There was a problem hiding this comment.
from what I tested I had to get rid of it before I could match things.
| ZIO.succeed(TestSuccess.Succeeded(BoolAlgebra.unit)) | ||
|
|
||
| case other => { | ||
| println(s"other = $other") |
|
@ghostdogpr We are going to change the signature of this to take an |
|
@adamgfraser ah ok that makes sense 👍 |
| /** | ||
| * Makes a new assertion that verifies a TestFailure matches a given failure | ||
| */ | ||
| final def testFails[E](failure: E): Assertion[TestFailure[E]] = { |
There was a problem hiding this comment.
maybe failsWith? @adamgfraser wdyt?
There was a problem hiding this comment.
I think we can simplify this. I am reviewing now.
| else BoolAlgebra.failure(AssertionValue(self, actual)) | ||
| } | ||
|
|
||
| final def isInstance[A](reference: A): Assertion[Any] = |
There was a problem hiding this comment.
I would take this out and use isSubType in your test.
| } | ||
|
|
||
| /** | ||
| * An aspect that makes a test succeed if it fails for any cause. |
There was a problem hiding this comment.
I think we need to update this a bit because it makes a test that failed for any reason into a success, it doesn't have to be because the test failed with a Cause. It could have just failed with an AssertionFailure. Also clarify that it makes a previously successful test into a failure.
| val failure: PerTest[Nothing, Any, Nothing, Any, Unit, Unit] = failure(Assertion.anything) | ||
|
|
||
| /** | ||
| * An aspect that makes a test succeed if it fails for a given cause. |
| def perTest[R >: Nothing <: Any, E >: Nothing <: E0, S >: Unit <: Unit]( | ||
| test: ZIO[R, TestFailure[E], TestSuccess[S]] | ||
| ): ZIO[R, TestFailure[E], TestSuccess[S]] = { | ||
| def fail(value: TestFailure[E]) = ZIO.fail( |
There was a problem hiding this comment.
Maybe you can inline these definitions into test.foldM since they are each only used once?
No description provided.