-
Couldn't load subscription status.
- Fork 1.4k
#1647-ExecutorSpec #1 #1742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1647-ExecutorSpec #1 #1742
Conversation
core-tests/shared/src/test/scala/zio/internal/ExecutorSpec.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great @XLPI ! run fmt to please the linter, then one small comment and it should be good to go.
core-tests/shared/src/test/scala/zio/internal/ExecutorSpec.scala
Outdated
Show resolved
Hide resolved
|
@regiskuckaertz please take a look again (also fixed by @ghostdogpr comments) |
|
Currently the suites are like this: But it should be: |
|
Oh, @ghostdogpr , I'll fix it |
|
@ghostdogpr done! |
|
UPD: FIxed for backward compatibility for Scala 2.11.12 |
|
@regiskuckaertz can we merge? |
|
Yes! Congratulations on your first PR 🎉 on to the next one 💪 |
|
WOW! @regiskuckaertz thanks! It was fascinatingly, interesting and amazing! |
|
@XLPI 🎉 |
Please review ExecutorSpec migration to zio