Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@XLPI
Copy link
Contributor

@XLPI XLPI commented Sep 21, 2019

Please review ExecutorSpec migration to zio

Copy link
Member

@regiskuckaertz regiskuckaertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @XLPI ! run fmt to please the linter, then one small comment and it should be good to go.

LGLO
LGLO previously approved these changes Sep 21, 2019
Alexander Korchagin and others added 2 commits September 21, 2019 19:31
@XLPI
Copy link
Contributor Author

XLPI commented Sep 21, 2019

@regiskuckaertz please take a look again (also fixed by @ghostdogpr comments)

@ghostdogpr
Copy link
Member

Currently the suites are like this:

[info] + ExecutorSpec
[info]   + Create the default unyielding executor and check that:
[info]     + When converted to an EC, it reports Throwables to stdout
[info]     + Create an executor that cannot have tasks submitted to and check that:
[info]       + It throws an exception upon submission
[info]       + When converted to an ExecutionContext, it throws an exception
[info]       + When created from an EC, throw when fed an effect
[info]     + Create a yielding executor and check that:
[info]       + Runnables can be submitted 
[info]       + When converted to an ExecutionContext, it accepts Runnables
[info]       + When created from an EC, must not throw when fed an effect 
[info]     + Create an unyielding executor and check that:
[info]       + Runnables can be submitted
[info]       + When converted to an ExecutionContext, it accepts Runnables

But it should be:

[info] + ExecutorSpec
[info]   + Create the default unyielding executor and check that:
[info]     + When converted to an EC, it reports Throwables to stdout
[info]   + Create an executor that cannot have tasks submitted to and check that:
[info]     + It throws an exception upon submission
[info]     + When converted to an ExecutionContext, it throws an exception
[info]     + When created from an EC, throw when fed an effect
[info]   + Create a yielding executor and check that:
[info]     + Runnables can be submitted 
[info]     + When converted to an ExecutionContext, it accepts Runnables
[info]     + When created from an EC, must not throw when fed an effect 
[info]   + Create an unyielding executor and check that:
[info]     + Runnables can be submitted
[info]     + When converted to an ExecutionContext, it accepts Runnables

Alexander Korchagin and others added 2 commits September 21, 2019 19:53
@XLPI
Copy link
Contributor Author

XLPI commented Sep 21, 2019

Oh, @ghostdogpr , I'll fix it

Alexander Korchagin and others added 2 commits September 21, 2019 20:12
@XLPI
Copy link
Contributor Author

XLPI commented Sep 21, 2019

@ghostdogpr done!

Alexander Korchagin and others added 4 commits September 21, 2019 20:48
@XLPI
Copy link
Contributor Author

XLPI commented Sep 21, 2019

UPD: FIxed for backward compatibility for Scala 2.11.12

@XLPI
Copy link
Contributor Author

XLPI commented Sep 21, 2019

@regiskuckaertz can we merge?

@regiskuckaertz
Copy link
Member

Yes! Congratulations on your first PR 🎉 on to the next one 💪

@regiskuckaertz regiskuckaertz merged commit 1c257aa into zio:master Sep 21, 2019
@XLPI
Copy link
Contributor Author

XLPI commented Sep 21, 2019

WOW! @regiskuckaertz thanks! It was fascinatingly, interesting and amazing!

@ghostdogpr
Copy link
Member

@XLPI 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants