Clear up some Chunk hotspots #1825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ec1c46 to
6574490
Compare
jdegoes
reviewed
Sep 26, 2019
| override def toArray[A1 >: A](implicit tag: ClassTag[A1]): Array[A1] = array.asInstanceOf[Array[A1]] | ||
|
|
||
| override def length: Int = array.length | ||
| override val length: Int = array.length |
There was a problem hiding this comment.
Another thing you can do: anytime length is referenced, instead put it into a local val. This way it won't go through invokevirtual like all (non-private[this]) val access does.
jdegoes
approved these changes
Sep 26, 2019
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we had to keep some things in
lazy valordefbefore because of specialization.I took a quick flamegraph of
StreamChunkSpecandChunk.Concatis a big hotspot. Making things a bit more eager lessens that.