Implement ZIO#timeoutFork #1856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGLO
previously approved these changes
Sep 30, 2019
| */ | ||
| final def timeoutFork(d: Duration): ZIO[R with Clock, E, Either[Fiber[E, A], A]] = | ||
| raceWith(ZIO.sleep(d))( | ||
| (exit, fiber) => ZIO.done(exit).map(Right(_)) <* fiber.interrupt, |
There was a problem hiding this comment.
IMO could be a bit more readable if fiber is renamed to timeoutFiber.
jdegoes
previously approved these changes
Oct 1, 2019
|
Oops, a few conflicts to resolve.., |
|
Conflicts resolved. |
jdegoes
approved these changes
Oct 1, 2019
ghostdogpr
pushed a commit
that referenced
this pull request
Oct 1, 2019
* implement Cause.Meta * fix access levels * make case class final * address review comments * migrate tests to ZIO Test * address review comments * fix type * fix another typo * pass `Data` in from above * implement flatMap * implement flatten * implement unsandbox via flatten * apply nonFlaky only on JVM * use jvm test aspect more * try ignoring tests * start reenabling tests * remove unused import * reenable more tests * Add ZSchedule.elapsed example to docs (#1871) * Add ZSchedule.elapsed example to docs * ignore flaky supervision test (#1874) * CircleCI improvements (#1859) * CircleCI improvements * CircleCI improvements, yaml fix * CircleCI improvements, yaml fix 2 * CircleCI improvements, yaml fix 3 * Implement ZIO#timeoutFork (#1856) * implement timeoutFork * address review comments
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
* implement timeoutFork * address review comments
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
* implement Cause.Meta * fix access levels * make case class final * address review comments * migrate tests to ZIO Test * address review comments * fix type * fix another typo * pass `Data` in from above * implement flatMap * implement flatten * implement unsandbox via flatten * apply nonFlaky only on JVM * use jvm test aspect more * try ignoring tests * start reenabling tests * remove unused import * reenable more tests * Add ZSchedule.elapsed example to docs (zio#1871) * Add ZSchedule.elapsed example to docs * ignore flaky supervision test (zio#1874) * CircleCI improvements (zio#1859) * CircleCI improvements * CircleCI improvements, yaml fix * CircleCI improvements, yaml fix 2 * CircleCI improvements, yaml fix 3 * Implement ZIO#timeoutFork (zio#1856) * implement timeoutFork * address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on discussion in #1824, adds a
timeoutForkmethod on ZIO that attempts to timeout an effect, but does not wait for the running effect to terminate. If the running effect does not complete before the timeout elapses a reference to the interrupting fiber will be returned, allowing the user to decide what further action to take (e.g. ignore it, wait a certain amount of time for it to succeed or else do something else).This can be useful when the effect is potentially uninterruptible to avoid waiting indefinitely on the effect to complete and possible apply further logic in that case.