Make asError argument call-by-name to match as
#1905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iravid
approved these changes
Oct 4, 2019
|
I think for consistency reasons this makes sense. One can debate whether or not it should be eager or by name, but by name at least affords tracing potential. |
jdegoes
approved these changes
Oct 4, 2019
|
Thank you! 🙏 |
neko-kai
added a commit
to 7mind/zio
that referenced
this pull request
Oct 4, 2019
neko-kai
added a commit
that referenced
this pull request
Oct 5, 2019
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled upon this because I wanted to avoid constructing an unnecessary error object when doing something like
someSuccessfulIO.asError(createError(...)). But I also noticedZIO.asis currently call-by-name but notasError. So seems like a good thing to do for consistency's sake anyway.I noticed this same mismatch in
ZSink.