Thanks to visit codestin.com
Credit goes to github.com

Skip to content

resolve #1891 Add ZEnv #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2019
Merged

resolve #1891 Add ZEnv #1915

merged 2 commits into from
Oct 9, 2019

Conversation

@mschuwalow
Copy link
Member

@mschuwalow mschuwalow commented Oct 5, 2019 •
edited
Loading

I went ahead and deleted DefaultRuntime#Environment as it's now useless in my opinion.

I had a quick skim through the docs and I don't think DefaultRuntime#Environment is mentioned anywhere else, but I might have missed something.

/cc @jdegoes

@mschuwalow mschuwalow changed the title resolve #1891: Add ZEnv resolve #1891\ Add ZEnv Oct 5, 2019
@mschuwalow mschuwalow changed the title resolve #1891\ Add ZEnv resolve #1891 Add ZEnv Oct 5, 2019
@mschuwalow mschuwalow force-pushed the feature/zenv-type-alias branch from 2ffb7e5 to cfa73a0 Compare October 5, 2019 23:16
@mschuwalow
Copy link
Member Author

Hmm I think it would be nicer to have ZEnv as an abstract type member in AbstractZIOPackage, but the 2.11 typechecker does not seem to like it for some reason 🤷‍♂️

@vasilmkd
Copy link
Contributor

vasilmkd commented Oct 6, 2019

You can check if everything is ok with the documentation by running doc from the root project.

LGLO
LGLO reviewed Oct 6, 2019
View reviewed changes
jdegoes
jdegoes reviewed Oct 8, 2019
View reviewed changes
LGLO
LGLO approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@LGLO LGLO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jdegoes jdegoes merged commit 02f2b2d into zio:master Oct 9, 2019
@jdegoes
Copy link
Member

jdegoes commented Oct 9, 2019

@mschuwalow Great work!

Twizty pushed a commit to Twizty/zio that referenced this pull request Nov 13, 2019
@mschuwalow @Twizty
resolve zio#1891 Add ZEnv (zio#1915)
6d6afa5 
* resolve zio#1891

* introduce zenvdefinition and move package objects back to shared
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdegoes jdegoes jdegoes approved these changes

@LGLO LGLO LGLO approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mschuwalow @vasilmkd @jdegoes @LGLO