Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ZIO Test: Fix Type Inference Issue with Assertion#equalTo #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2019
Merged

ZIO Test: Fix Type Inference Issue with Assertion#equalTo #1946

merged 2 commits into from
Oct 10, 2019

Conversation

@adamgfraser
Copy link
Contributor

Resolves #1562.

@darl
Copy link
Contributor

darl commented Oct 10, 2019

Can this also be simplified?
https://github.com/zio/zio/blob/master/core-tests/shared/src/test/scala/zio/ZManagedSpec.scala#L750

@adamgfraser
Copy link
Contributor Author

@darl Yes.

@adamgfraser adamgfraser requested a review from jdegoes October 10, 2019 18:41
jdegoes
jdegoes approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@jdegoes jdegoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Looks pleasant to use now!

@adamgfraser adamgfraser merged commit 008c851 into zio:master Oct 10, 2019
@adamgfraser adamgfraser deleted the 1562 branch October 10, 2019 18:53
@adamgfraser
Copy link
Contributor Author

Thanks to @jdegoes for posting the fix and to @regiskuckaertz and @ioleo for raising the issue. Really excited to finally have this one resolved!

regiskuckaertz
regiskuckaertz reviewed Oct 10, 2019
View reviewed changes
Copy link
Member

@regiskuckaertz regiskuckaertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍😍😍

Twizty pushed a commit to Twizty/zio that referenced this pull request Nov 13, 2019
@adamgfraser @Twizty
ZIO Test: Fix Type Inference Issue with Assertion#equalTo (zio#1946)
87ea1cf 
* fix type inference issue

* simplify ZManagedSpec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@regiskuckaertz regiskuckaertz regiskuckaertz left review comments

@jdegoes jdegoes jdegoes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ZIO Test: Type Inference Issue with Assertion#equalTo

4 participants

@adamgfraser @darl @jdegoes @regiskuckaertz