Implement ZIO#forkInternal to Prevent Spurious Warnings #1949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGLO
reviewed
Oct 11, 2019
| mapM(f andThen UIO.succeed) | ||
|
|
||
| /** | ||
| * Effectually maps over the favlue the fiber computes. |
There was a problem hiding this comment.
Thanks! Fixed now.
| * Forks an effect that will be executed without unhandled failures being | ||
| * reported. This is useful for implementing combinators that handle failures | ||
| * themselves. | ||
| */ |
ghostdogpr
previously approved these changes
Oct 11, 2019
jdegoes
reviewed
Oct 13, 2019
| /** | ||
| * Traverses the `Exit` with an effectual function. | ||
| */ | ||
| def traverse[R, E1 >: E, B](f: A => ZIO[R, E1, B]): ZIO[R, Nothing, Exit[E1, B]] = |
There was a problem hiding this comment.
👍 Let's add foreach alias too, if it doesn't exist.
jdegoes
reviewed
Oct 13, 2019
| * themselves. | ||
| */ | ||
| private[zio] final def forkInternal: ZIO[R, Nothing, Fiber[E, A]] = | ||
| run.fork.map(_.mapM(IO.done)) |
jdegoes
approved these changes
Oct 13, 2019
ghostdogpr
pushed a commit
to ghostdogpr/scalaz-zio
that referenced
this pull request
Nov 5, 2019
* implement forkInternal * fix typo * add foreach alias
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
* implement forkInternal * fix typo * add foreach alias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we generate a lot of spurious fiber failure warnings. For example, consider:
This will succeed because
foldCauserecovers from all errors. But a fiber failure warning will still be printed to the console because one of the forked fibers inraceWith, whichzipParis implemented in terms of, ended in failure. This is undesirable in general and particularly confusing to new users who don't understand why the warning is displayed or that the success of their effect is independent of this warning.This PR implements a new combinator
forkInternalthat forks an effect that will be executed without unhandled failures being reported. This can be use in combinators such asraceWiththat implement their own logic for handling failures to avoid these spurious warnings being generated.So far I have only used this in
raceWith, which seems to be the cause of most of the spurious warnings that are being reported, but we should be able to use this in other combinators as well.