introduce ZEnv decorators #1957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdegoes
requested changes
Oct 12, 2019
|
Just my 2c here on naming – why |
|
I like Kai's suggestion for names. Then we can have mapAll for the one that maps all the services. |
Agreed. I'll push an updated version in a bit |
jdegoes
approved these changes
Oct 13, 2019
|
Really nice work! Going to make pinpoint modifications of part of a standard environment really easy. |
ghostdogpr
pushed a commit
to ghostdogpr/scalaz-zio
that referenced
this pull request
Nov 5, 2019
* introduce ZEnv decorators * add zenvDecorator function * update docs * fix typo * update mdoc * update naming
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
* introduce ZEnv decorators * add zenvDecorator function * update docs * fix typo * update mdoc * update naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#resolve #1953
Also, there was a stray reference to DefaultRuntime#Environment that I missed in the BuildHelper.
Interestingly, we can write a fully generic version of this in zio-macros without introducing any new macros. I'll open a pr there later.
/cc @adamgfraser @jdegoes