Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@adamgfraser
Copy link
Contributor

Resolves #1960.

@adamgfraser adamgfraser requested a review from jdegoes October 13, 2019 23:05
jdegoes
jdegoes previously approved these changes Oct 23, 2019
Copy link
Member

@jdegoes jdegoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic The only other thing I might propose is adding ifEnvSet(env) as a shortcut for ifEnv(env, anything).

@adamgfraser
Copy link
Contributor Author

All set.

@jdegoes jdegoes merged commit be4698b into zio:master Oct 24, 2019
@jdegoes
Copy link
Member

jdegoes commented Oct 24, 2019

🎉

@adamgfraser adamgfraser deleted the 1960 branch October 27, 2019 17:29
ghostdogpr pushed a commit to ghostdogpr/scalaz-zio that referenced this pull request Nov 5, 2019
* implement TestAspect#ifEnv

* migrate tests

* add convenience methods

* remove dead code

* fix cross version compatibility issue

* fix tests
Twizty pushed a commit to Twizty/zio that referenced this pull request Nov 13, 2019
* implement TestAspect#ifEnv

* migrate tests

* add convenience methods

* remove dead code

* fix cross version compatibility issue

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZIO Test: Add ifEnv TestAspect

2 participants