Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ZIO Test: Refactor FailureDetails #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 24, 2019
Merged

ZIO Test: Refactor FailureDetails #1985

merged 5 commits into from
Oct 24, 2019

Conversation

@adamgfraser
Copy link
Contributor

Resolves #1332.

All inner failures when now be reported when there are multiple nested failures. For example, this assertion failure would now be reported like so:

assert(Right(Some(3)), isRight(isSome(isGreaterThan(4)))

Right(Some(3)) did not satisfy isRight(isSome(isGreaterThan(4)))
Some(3) did not satisfy isSome(isGreaterThan(4))
3 did not satisfy isGreaterThan(4)

Previously only the "inner most" and "outer most" failures would be reported.

@adamgfraser adamgfraser requested a review from jdegoes October 16, 2019 03:54
jdegoes
jdegoes reviewed Oct 23, 2019
View reviewed changes
Copy link
Member

@jdegoes jdegoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work!

I'd only flip the rendering so the "smallest" error appears first.

@adamgfraser
Copy link
Contributor Author

Good idea. Done now.

@jdegoes jdegoes merged commit 1250437 into zio:master Oct 24, 2019
@jdegoes
Copy link
Member

jdegoes commented Oct 24, 2019

🎉

@adamgfraser adamgfraser deleted the 1332 branch October 27, 2019 17:28
ghostdogpr pushed a commit to ghostdogpr/scalaz-zio that referenced this pull request Nov 5, 2019
@adamgfraser
ZIO Test: Refactor FailureDetails (zio#1985)
7fde388 
* refactor FailureDetails

* fix Scala 2.11 compatibility issues

* flip rendering

* update SummaryBuilderSpec
Twizty pushed a commit to Twizty/zio that referenced this pull request Nov 13, 2019
@adamgfraser @Twizty
ZIO Test: Refactor FailureDetails (zio#1985)
1c95c02 
* refactor FailureDetails

* fix Scala 2.11 compatibility issues

* flip rendering

* update SummaryBuilderSpec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdegoes jdegoes jdegoes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ZIO Test: Refactor FailureDetails

2 participants

@adamgfraser @jdegoes