Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add ZSink.splitOn #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 23, 2019
Merged

Add ZSink.splitOn #2006

merged 6 commits into from
Oct 23, 2019

Conversation

@regiskuckaertz
Copy link
Member

I can add a maximum frame length if it makes sense, let me know what you think.

Closes #1965

@regiskuckaertz regiskuckaertz requested a review from iravid October 20, 2019 09:06
vasilmkd
vasilmkd reviewed Oct 21, 2019
View reviewed changes
Copy link
Contributor

@vasilmkd vasilmkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition.

Just an idea. Would a final def splitWith(p: A => Boolean): ZSink[Any, Nothing, A, A, Chunk[A] combinator make sense?

vasilmkd
vasilmkd approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@vasilmkd vasilmkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@regiskuckaertz
Copy link
Member Author

Yes splitWith makes sense imo 🤔

@iravid
Copy link
Member

iravid commented Oct 22, 2019

Will review tonight!

iravid
iravid approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Awesome work @regiskuckaertz!

@iravid iravid merged commit f64b5ca into zio:master Oct 23, 2019
ghostdogpr pushed a commit to ghostdogpr/scalaz-zio that referenced this pull request Nov 5, 2019
Add ZSink.splitOn (zio#2006)
24366f8 
* Add `ZSink.splitOn`

* Comment

* Feedback

* Use same generator

* fmt
Twizty pushed a commit to Twizty/zio that referenced this pull request Nov 13, 2019
@Twizty
Add ZSink.splitOn (zio#2006)
dddf91a 
* Add `ZSink.splitOn`

* Comment

* Feedback

* Use same generator

* fmt
@regiskuckaertz regiskuckaertz deleted the rk-spliton branch November 25, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iravid iravid iravid approved these changes

+1 more reviewer

@vasilmkd vasilmkd vasilmkd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ZSink.splitDelimiter

3 participants

@regiskuckaertz @iravid @vasilmkd