Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Mock improvements #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 22, 2019
Merged

Mock improvements #2000

merged 6 commits into from
Oct 22, 2019

Conversation

@ioleo
Copy link
Member

@ioleo ioleo commented Oct 18, 2019 •
edited
Loading

  • Rename succeed to empty, to express its purpose.
  • Add scaladoc for MockSpec.
  • Add expectsNothing utility method.
  • Rename MockSpec to Expectation
  • Remove the need to for Managed[Nothing, Module] hint
  • Better API for constructing expecations
  • Drop Service container for tags
  • refactor ExpectationSpec to ZIO Test

@ioleo ioleo changed the title Mock improvements WIP: Mock improvements Oct 18, 2019
@ioleo ioleo mentioned this pull request Oct 18, 2019
Closed
10 tasks
@ioleo ioleo force-pushed the mock-improvements branch 5 times, most recently from edbadf6 to c4ace7c Compare October 20, 2019 21:34
@ioleo ioleo force-pushed the mock-improvements branch 2 times, most recently from b139f32 to 1c108d1 Compare October 20, 2019 21:49
@ioleo
Copy link
Member Author

ioleo commented Oct 20, 2019

Will provide updates to documentation as a seperate PR.

@ioleo
Rename MockSpec to Expectation, improve type inference, expose better…
571a716 
… API, drop Service container for method tags
@ioleo ioleo force-pushed the mock-improvements branch from 1c108d1 to 571a716 Compare October 20, 2019 22:09
@ioleo ioleo changed the title WIP: Mock improvements Mock improvements Oct 20, 2019
@ioleo
Copy link
Member Author

ioleo commented Oct 20, 2019

@adamgfraser Ready for review.

@ioleo ioleo mentioned this pull request Oct 20, 2019
Closed
@adamgfraser adamgfraser mentioned this pull request Oct 21, 2019
Closed
21 tasks
adamgfraser
adamgfraser suggested changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! It makes mocking easier to use, and I love the move to ZIO Test for the internal tests. A couple of questions / comments on the use of implicits and if we can make them a little less "magical". Other than that just a few minor typos.

@ioleo ioleo force-pushed the mock-improvements branch 3 times, most recently from dfce174 to b57e92a Compare October 21, 2019 20:34
ioleo
ioleo commented Oct 21, 2019
View reviewed changes
@ioleo ioleo force-pushed the mock-improvements branch from b57e92a to b49e216 Compare October 21, 2019 21:05
@ioleo
Copy link
Member Author

ioleo commented Oct 22, 2019

@adamgfraser I think it's ready to be merged.

@adamgfraser adamgfraser merged commit 8cd3da5 into zio:master Oct 22, 2019
@ioleo ioleo deleted the mock-improvements branch October 22, 2019 15:02
ghostdogpr pushed a commit to ghostdogpr/scalaz-zio that referenced this pull request Nov 5, 2019
@ioleo
Mock improvements (zio#2000)
2e746ad 
* Rename succeed to empty & add doc

* Rename MockSpec to Expectation, improve type inference, expose better API, drop Service container for method tags

* Refactor ExpectationSpec to ZIO Test

* Variance typos

* Code review

* Add shapeless attribution
Twizty pushed a commit to Twizty/zio that referenced this pull request Nov 13, 2019
@ioleo @Twizty
Mock improvements (zio#2000)
8c78e80 
* Rename succeed to empty & add doc

* Rename MockSpec to Expectation, improve type inference, expose better API, drop Service container for method tags

* Refactor ExpectationSpec to ZIO Test

* Variance typos

* Code review

* Add shapeless attribution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ioleo @adamgfraser