Add TMap #2017
Merged
Add TMap #2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdegoes
previously requested changes
Oct 23, 2019
| * Makes a new `TMap` that is initialized with the specified values. | ||
| */ | ||
| final def apply[K, V](data: => List[(K, V)]): STM[Nothing, TMap[K, V]] = { | ||
| val capacity = if (data.isEmpty) DefaultCapacity else 2 * data.size |
There was a problem hiding this comment.
I would change to varargs (like most collections) and add a fromIterable method that takes an Iterable (not List).
| /** | ||
| * Creates new [[TMap]] by mapping all bindings using pure function. | ||
| */ | ||
| final def map[K2, V2](f: ((K, V)) => (K2, V2)): STM[Nothing, TMap[K2, V2]] = |
There was a problem hiding this comment.
Personally I find these pure methods confusing. I would delete map and mapM, leaving only transform and transformM
| buckets <- tBuckets.get | ||
| idx <- indexOf(k) | ||
| _ <- buckets.update(idx, upsert) | ||
| data <- self.fold(List.empty[(K, V)])((acc, kv) => kv :: acc) |
There was a problem hiding this comment.
Doesn't this grab the whole contents of the map, even if there is no need to resize? We should aim for maximum laziness to avoid doing unnecessary worm
There was a problem hiding this comment.
Good point, stored the size in TRef.
jdegoes
reviewed
Oct 23, 2019
| /** | ||
| * Atomically updates all values using effectful function. | ||
| */ | ||
| final def transformValuesM[E](f: V => STM[E, V]): STM[E, Unit] = |
jdegoes
reviewed
Oct 23, 2019
| /** | ||
| * Removes bindings matching predicate. | ||
| */ | ||
| final def removeIf(p: ((K, V)) => Boolean): STM[Nothing, Unit] = |
There was a problem hiding this comment.
Why a tuple ((K, V)) instead of (K, V) (Function2).
jdegoes
reviewed
Oct 23, 2019
| /** | ||
| * Retains bindings matching predicate. | ||
| */ | ||
| final def retainIf(p: ((K, V)) => Boolean): STM[Nothing, Unit] = |
There was a problem hiding this comment.
Why a tuple ((K, V)) instead of (K, V) (Function2).
|
@jdegoes removed tupled parameters, refactored |
jdegoes
reviewed
Oct 24, 2019
| /** | ||
| * Atomically performs side-effect for each binding present in map. | ||
| */ | ||
| final def foreach[E](f: ((K, V)) => STM[E, Unit]): STM[E, Unit] = |
There was a problem hiding this comment.
Nested tuple ((K, V)) instead of 2 param function here will make it harder to use in general.
jdegoes
previously requested changes
Oct 24, 2019
jdegoes
approved these changes
Oct 24, 2019
|
Awesome work! 🎉 |
ghostdogpr
pushed a commit
to ghostdogpr/scalaz-zio
that referenced
this pull request
Nov 5, 2019
* Draft the TMap API * Add test skeleton * Create zio-test template for TMapSpec * Initialize TMap * Reformat sources * Implement map lookups * Implement element insertion * Implement removal * Implement filtering * Rearrange companion's methods * Rename suite * Implement fold * Change internal TMap representation * Reduce code duplication * Implement map * Rename filter/filterNot to retainIf/removeIf * Introduce rehashing into map function * Implement foldM * Implement mapM * Document the API * Make capacity flexible * Remove accessM helper * Implement resizing * Align val names * Add fromIterable factory * Update apply factory to use varargs * Cache the total number of elements * Replace map/mapM with transform/transformM * Update size when needed * Insert element in non-empty bucket * Remove unnecessary vals * Remove unnecessary error parameter * Add transformValues and transformValuesM * Remove error type from contains * Drop tuples in favor of multiple args * Remove unnecessary reversing * Update the existing TArray instead of creating new * Remove self-type * Add toList conversion * Add keys and values lookups * Remove code duplication * Express transform in terms of transformM * Inline unused helper * Remove more duplicates * Align code format * Express fold in terms of foldM * Reorder private methods * Revert "Express fold in terms of foldM" This reverts commit 6124f9a. * Rename collectWith to collectM * Specialize transform and transformM * Remove tupled param from foreach
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
* Draft the TMap API * Add test skeleton * Create zio-test template for TMapSpec * Initialize TMap * Reformat sources * Implement map lookups * Implement element insertion * Implement removal * Implement filtering * Rearrange companion's methods * Rename suite * Implement fold * Change internal TMap representation * Reduce code duplication * Implement map * Rename filter/filterNot to retainIf/removeIf * Introduce rehashing into map function * Implement foldM * Implement mapM * Document the API * Make capacity flexible * Remove accessM helper * Implement resizing * Align val names * Add fromIterable factory * Update apply factory to use varargs * Cache the total number of elements * Replace map/mapM with transform/transformM * Update size when needed * Insert element in non-empty bucket * Remove unnecessary vals * Remove unnecessary error parameter * Add transformValues and transformValuesM * Remove error type from contains * Drop tuples in favor of multiple args * Remove unnecessary reversing * Update the existing TArray instead of creating new * Remove self-type * Add toList conversion * Add keys and values lookups * Remove code duplication * Express transform in terms of transformM * Inline unused helper * Remove more duplicates * Align code format * Express fold in terms of foldM * Reorder private methods * Revert "Express fold in terms of foldM" This reverts commit 6124f9a. * Rename collectWith to collectM * Specialize transform and transformM * Remove tupled param from foreach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1178 (finally)