Properly name ZStream#mapConcat* combinators #2012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm yes, I thought we fixed that before. The |
|
No problem, disregard this PR in its current state, because it's not correct according to that requirement. |
|
@iravid I did as you suggested. Ready for review. |
iravid
approved these changes
Oct 22, 2019
ghostdogpr
pushed a commit
to ghostdogpr/scalaz-zio
that referenced
this pull request
Nov 5, 2019
* Rename ZStream#mapConcat to ZStream#mapConcatChunk * Add ZStream#mapConcat * Add missing ZStream#mapConcatChunkM tests * Add ZStream#mapConcatM * Add ZStreamChunk#mapConcat*M combinators
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
* Rename ZStream#mapConcat to ZStream#mapConcatChunk * Add ZStream#mapConcat * Add missing ZStream#mapConcatChunkM tests * Add ZStream#mapConcatM * Add ZStreamChunk#mapConcat*M combinators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a discrepancy between the function signatures of
ZStream#mapConcatandZStreamChunk#mapConcat(which is actuallyZStreamChunk#mapConcatChunk.@iravid WDYT we should do? Is there a good use case for
ZStreamChunk#mapConcatthat accepts a function that returns anIterable, instead of aChunk?