Add ZManaged.makeInterruptible #2046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
neko-kai
commented
Oct 28, 2019
- use bracketExit in ZManaged.exit/First
* use bracketExit in ZManaged.exit/First
iravid
reviewed
Oct 28, 2019
iravid
reviewed
Oct 28, 2019
| a <- ZIO.done(exitA) | ||
| } yield a | ||
| }, | ||
| acquire = ZIO.bracketExit(self.reserve)( |
There was a problem hiding this comment.
Curious, what's the motivation for the change? The differences are mainly correct usage of ZIOFn and error preservation (which shouldn't matter here because finalizer.set is a UIO)
There was a problem hiding this comment.
@iravid Less low-level code; also this is the only instance of uninterruptibleMask(restore(_).catch) aside of bracketExit in core and turns out it just duplicates it – making it just reuse bracketExit also safeguards it against any changes to finalizer behavior :)
iravid
approved these changes
Oct 28, 2019
ghostdogpr
pushed a commit
to ghostdogpr/scalaz-zio
that referenced
this pull request
Nov 5, 2019
* Add ZManaged.makeInterruptible * use bracketExit in ZManaged.exit/First * Fix ZManaged.makeInterruptible scaladoc
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
* Add ZManaged.makeInterruptible * use bracketExit in ZManaged.exit/First * Fix ZManaged.makeInterruptible scaladoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.