Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@simpadjo
Copy link
Contributor

@simpadjo simpadjo commented Nov 2, 2019

closes #1886

vasilmkd
vasilmkd previously approved these changes Nov 2, 2019
@simpadjo simpadjo changed the title Rename ZStream#transduce, ZStream#aggregate, ZStream#aggregateWithin #1886 Rename ZStream#transduce, ZStream#aggregate, ZStream#aggregateWithin Nov 2, 2019
@vasilmkd
Copy link
Contributor

vasilmkd commented Nov 2, 2019

Tip: edit the original comment to "Resolves #1886" in order to close the accompanying issue when this is merged. You'll see Resolves becomes underlined.

@simpadjo
Copy link
Contributor Author

simpadjo commented Nov 2, 2019

done

Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could we keep transduce and transduceManaged as aliases for aggregate and aggregateManaged?

@simpadjo
Copy link
Contributor Author

simpadjo commented Nov 3, 2019

Done

@simpadjo simpadjo requested a review from iravid November 3, 2019 10:18
@iravid iravid merged commit aab9b41 into zio:master Nov 3, 2019
ghostdogpr pushed a commit to ghostdogpr/scalaz-zio that referenced this pull request Nov 5, 2019
…io#2099)

* rename ZStream#aggregateWithin => aggregateAsyncWithin

* rename ZStream#aggregate => ZStream#aggregateAsync

* rename ZStream#transduce => ZStream#aggregate

* amend

* Keep ZStream#transdue and transduceManaged as aliases, restore alphabetical order
Twizty pushed a commit to Twizty/zio that referenced this pull request Nov 13, 2019
…io#2099)

* rename ZStream#aggregateWithin => aggregateAsyncWithin

* rename ZStream#aggregate => ZStream#aggregateAsync

* rename ZStream#transduce => ZStream#aggregate

* amend

* Keep ZStream#transdue and transduceManaged as aliases, restore alphabetical order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename ZStream#transduce, ZStream#aggregate, ZStream#aggregateWithin

3 participants