Port absorb and absorbWith combinators to ZManaged #2116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iravid
requested changes
Nov 3, 2019
|
Would be great if you could add a test for |
|
@iravid I've alphabetized the methods and added tests. There were no existing tests for Now we're in the same situation again where If the |
|
@alexvanolst I tried to fix the conflicts but messed up the formatting. Can you run an fmt here? Then we can merge this. Great work here! |
|
Thank you @alexvanolst! |
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
* Port absorb and absorbWith combinators to ZManaged * Move ZManaged#absorb and absorbWith to be alphabetically orderd * Add ZIO absorbWith tests * Port ZIO run to ZManaged * Add absorbWith tests to ZManaged * Run scalafmt after merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2077
These were trivial to port over and seem to make sense to me.