Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add new shorthands for running ZStream #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 3, 2019
Merged

Add new shorthands for running ZStream #2113

merged 4 commits into from
Nov 3, 2019

Conversation

@alexvanolst
Copy link
Contributor

Resolves #1491

Since there was an "open" question on the behaviour of head two variants were added.

head which is equivalent to take(1) and is safe for infinite streams
first which consumes the entire stream (i.e. the inverse of last)

@adamgfraser
Copy link
Contributor

Just my two cents first seems like a dangerous operation. I don't know if we should have a shortcut for it.

@alexvanolst
Copy link
Contributor Author

I wouldn't say I'm sold on it either. @iravid Since you raised the question on whether it should have that behaviour, what do you think?

@iravid
Copy link
Member

iravid commented Nov 3, 2019

Yes, I'm not sold either. Let's drop first. Anyone who figures out they need it can probably implement it manually :-)

Could you add tests for head and last?

@regiskuckaertz
Copy link
Member

It seems to me these should go into ZSink instead no?

iravid
iravid requested changes Nov 3, 2019
View reviewed changes
@alexvanolst
Copy link
Contributor Author

@regiskuckaertz I don't think head makes too much sense as part of ZSink.
For last we could add it to ZSink and keep the shorthand using it.

@iravid
Copy link
Member

iravid commented Nov 3, 2019

Yeah, ZSink.head and ZSink.last would be useful. I'll add another ticket for those.

@iravid
Copy link
Member

iravid commented Nov 3, 2019

As currently implemented, head wouldn't make sense on ZSink, no. It can be implemented using run and a ZSink that keeps the first element. No need to do it in this PR though.

@alexvanolst
Copy link
Contributor Author

I've added the tests. @iravid Feel free to assign / ping me when you create that other ticket.

@iravid iravid merged commit c54c8bd into zio:master Nov 3, 2019
@alexvanolst alexvanolst deleted the 1491-shorthands-for-running-stream branch November 3, 2019 14:11
simpadjo
simpadjo reviewed Nov 3, 2019
View reviewed changes
ghostdogpr pushed a commit to ghostdogpr/scalaz-zio that referenced this pull request Nov 5, 2019
@alexvanolst
Add ZStream#runHead, runLast (zio#2113)
1b9b0d6 
* Add new shorthands for running ZStream

* Remove ZStream#first

* Add tests for ZStream head and last

* Rename ZStream head and last to runHead and runLast
Twizty pushed a commit to Twizty/zio that referenced this pull request Nov 13, 2019
@alexvanolst @Twizty
Add ZStream#runHead, runLast (zio#2113)
ec9559d 
* Add new shorthands for running ZStream

* Remove ZStream#first

* Add tests for ZStream head and last

* Rename ZStream head and last to runHead and runLast
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iravid iravid iravid approved these changes

+1 more reviewer

@simpadjo simpadjo simpadjo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add more shorthands for running streams

5 participants

@alexvanolst @adamgfraser @iravid @regiskuckaertz @simpadjo