Make parts of ZManaged private #2124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iravid
requested changes
Nov 3, 2019
| /** | ||
| * Extracts [[Reservation]] from within. | ||
| */ | ||
| final def unapply[E, A](v: Managed[E, A]): Option[ZIO[Any, E, Reservation[Any, E, A]]] = |
There was a problem hiding this comment.
We can skip unapply. No real use for it
| * some checked error, as per the type of the functions provided by the resource. | ||
| */ | ||
| final case class ZManaged[-R, +E, +A](reserve: ZIO[R, E, Reservation[R, E, A]]) { self => | ||
| final class ZManaged[-R, +E, +A] private (val reserve: ZIO[R, E, Reservation[R, E, A]]) extends Serializable { self => |
There was a problem hiding this comment.
Let's make reserve just a constructor parameter, and not a field:
Suggested change
| final class ZManaged[-R, +E, +A] private (val reserve: ZIO[R, E, Reservation[R, E, A]]) extends Serializable { self => | |
| final class ZManaged[-R, +E, +A] private (reservation: ZIO[R, E, Reservation[R, E, A]]) extends Serializable { self => |
And add an accessor method:
def reserve: ZIO[R, E, Reservation[R, E, A]] = reservation|
@iravid Thank you for your review, I addressed the issues. |
ghostdogpr
pushed a commit
to ghostdogpr/scalaz-zio
that referenced
this pull request
Nov 5, 2019
* Make parts of ZManaged private * Make ZManaged serializable * Address code remarks
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
* Make parts of ZManaged private * Make ZManaged serializable * Address code remarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2076