Ignore should not recover from unchecked exceptions #2148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
reviewed
Nov 4, 2019
|
The change breaks the tests “Invokes cleanups on interrupt“ in ZManagedSpec because they expect the old behavior. I think you can just adapt those tests. |
ghostdogpr
approved these changes
Nov 4, 2019
iravid
approved these changes
Nov 4, 2019
There was a problem hiding this comment.
Thanks @alexvanolst, this makes sense! Defect recovery should really be limited to sandbox/run/foldCauseM.
ghostdogpr
pushed a commit
to ghostdogpr/scalaz-zio
that referenced
this pull request
Nov 5, 2019
* Ignore should not recover from unchecked exceptions * Remove unused imports from ignore test * Fix ZManaged tests relying on old .ignore behaviour * Fix StreamSpec tests relying on old ZIO.ignore behaviour
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
* Ignore should not recover from unchecked exceptions * Remove unused imports from ignore test * Fix ZManaged tests relying on old .ignore behaviour * Fix StreamSpec tests relying on old ZIO.ignore behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2142