ZIO Test: Implement Overloaded Version of TestAspect#nonFlaky #2140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
approved these changes
Nov 4, 2019
vasilmkd
reviewed
Nov 4, 2019
Comment on lines
+346
to
+347
| val nonFlaky: TestAspectPoly = | ||
| nonFlaky(100) |
There was a problem hiding this comment.
Not that I don't appreciate this change, far from it, but why didn't you use default arguments, of course, in the original function declaration, like so:
def nonFlaky(n0: Int = 100): TestAspectPoly = ???
There was a problem hiding this comment.
If you do that then you would need to call the method as nonFlaky() instead of nonFlaky. That is somewhat irregular (no other test aspect is called that way and it gives the impression that it is possibly an impure method) so I think it is nicer to do it this way, especially when it is only a few extra lines of code.
There was a problem hiding this comment.
Well, you answered my question 😄
ghostdogpr
pushed a commit
to ghostdogpr/scalaz-zio
that referenced
this pull request
Nov 5, 2019
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nonFlakyis a commonly used test aspect. Currently the user has to specify the number of times for the test to be repeated. This PR adds an overloaded version that repeats a test a default number of times determined by the test framework (currently set at 100). I think this makes it a little nicer. Users can still specify a number of repetitions if they want.