Add sandboxWith to ZManaged #2151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somehow 2 ZIOSpec tests failed. I am not sure if they are flaky because I can't see how this changes affect them but I will take a look at it |
|
I am not able to reproduce these failures. Can someone re-trigger the tests, perhaps they are flaky? @iravid @adamgfraser . Failing tests are ZIO -> ForkAll -> propagates defects |
|
Can you mark the test as |
iravid
approved these changes
Nov 5, 2019
|
Thanks @saraiva132! |
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
* Add sandboxWith to ZManaged * mark flaky test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.