Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Chunk#flatMap construct result array from the back #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2019
Merged

Chunk#flatMap construct result array from the back #2165

merged 1 commit into from
Nov 6, 2019

Conversation

@vasilmkd
Copy link
Contributor

@vasilmkd vasilmkd commented Nov 6, 2019

regiskuckaertz
regiskuckaertz previously approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@regiskuckaertz regiskuckaertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@iravid
Copy link
Member

iravid commented Nov 6, 2019

I’m all for optimizations but this one needs to be benchmarked, as not many things are faster than preprnding to a list

@iravid
Copy link
Member

iravid commented Nov 6, 2019

See http://www.lihaoyi.com/post/BenchmarkingScalaCollections.html#construction-performance

@vasilmkd
Copy link
Contributor Author

vasilmkd commented Nov 6, 2019

Hmmm, TIL. Thanks. I have another idea.

@vasilmkd vasilmkd changed the title Use ListBuffer instead of reversing Lists in Chunk Chunk#flatMap construct result array from the back Nov 6, 2019
@vasilmkd
Copy link
Contributor Author

vasilmkd commented Nov 6, 2019 •
edited
Loading

@iravid How about now? 🤣

iravid
iravid approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@iravid iravid merged commit b975891 into zio:master Nov 6, 2019
@vasilmkd vasilmkd deleted the chunk-flatmap-listbuffer branch November 6, 2019 13:22
Twizty pushed a commit to Twizty/zio that referenced this pull request Nov 13, 2019
@vasilmkd @Twizty
Optimize Chunk#flatMap by saving a list reversal (zio#2165)
d6a6c30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iravid iravid iravid approved these changes

@regiskuckaertz regiskuckaertz Awaiting requested review from regiskuckaertz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vasilmkd @iravid @regiskuckaertz