You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finaldefcheckM[R, E, A](rv: Gen[R, A])(test: A=>ZIO[R, E, TestResult]):ZIO[R, E, TestResult]
The curried syntax is quite nice for ergonomics and writing tests in a property based style, but there can be a type inference issue if the test requires an additional environment beyond what the generator does because the compiler determines the R type after looking at the first parameter without considering the second.
This PR resolves this by changing the signature to be:
finaldefcheckM[R, R1<:R, E, A](rv: Gen[R, A])(test: A=>ZIO[R1, E, TestResult]):ZIO[R1, E, TestResult]
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. The partial type application trick used in things like timeoutTo in ZIO could also work (and in fact, works better in some cases). Did you try this on anything else to make sure it has the intended effects on type inference?
Yes, I thought about that and agree that would work too.
In my experiments the type inference worked quite well. The main thing I was worried about was that since we are stating that R1 <: R there would be an issue if R1 was actually a supertype of R (e.g. the generator requires Random but the test doesn't require any effect). However, since R is contravariant the type can automatically be narrowed which I think may make this work a little better for the R parameter than the other parameters. I tested it with an effect that required a completely different environment (e.g. generator requires random, test requires clock) and that worked as well. We have also used this pattern in Live#withLive and I haven't seen any issues there.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current signature of
checkMis:The curried syntax is quite nice for ergonomics and writing tests in a property based style, but there can be a type inference issue if the test requires an additional environment beyond what the generator does because the compiler determines the
Rtype after looking at the first parameter without considering the second.This PR resolves this by changing the signature to be: