ZIO Test: Move Check Variants Back Into Package Object #2181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been having an issue with using the
checkvariants from within ZIO Test because apparently due to a compiler bug there is a spurious compilation failure for "illegal premature access to the unconstructed this" due to the ZIO Test package object inheritingCheckVariantsand thecheckmethods being overloaded. Previously I had been of the view that it was a minor annoyance and it was nice not having the check variants in the package object to keep it smaller. But it is getting annoying for contributors who are exploring building functionality on top of it so I think time to make a change.