Make ZStream.unfold safe to pull again #2199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iravid
reviewed
Nov 10, 2019
| case None => Pull.end | ||
| } | ||
| ) | ||
| done <- Ref.make(false).toManaged_ |
There was a problem hiding this comment.
So we can use Pull.memoizeEnd here right?
Pull.memoizeEnd {
Ref.make(s).toManaged_.map {
// previous code here
}
}
|
I started disliking |
|
So let's fix it, by not capturing the error, or delete it? |
|
I vote for deleting |
iravid
approved these changes
Nov 10, 2019
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
…o#2199) * Check that ZStream.unfold is safe to pull again * Make ZStream.unfoldM safe to pull again * Adjust ZStream.unfold test * Remove StreamEffect.memoizeEnd * Remove ZStream.Pull.memoizeEnd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@iravid