ZIO Test: Improve Order of Parameters in CheckSome #2224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdegoes
approved these changes
Nov 15, 2019
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 18, 2019
* use partial application * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current signature of
checkSomeis a bit irregular because it takes a generator, then a size, then the test. Normally in ZIO combinators likeforeachParNwould take thenparameter first. We originally had it this way but had to change it when we added the overloaded variants for multiple generators because it created ambiguity since the first parameter list was the same.This PR uses the partial application to restore the order so the size parameter is first. I think this is a little nicer and more regular with the rest of ZIO though it does add a little complexity and make the methods a bit less discoverable.