Thanks to visit codestin.com
Credit goes to github.com

Skip to content

scala 2.12.7 and sbt 1.2.3 #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2018
Merged

scala 2.12.7 and sbt 1.2.3 #275

merged 1 commit into from
Sep 30, 2018

Conversation

@pshirshov
Copy link
Member

Just a minor update. 2.12.7 has fixed some jdk 10 compatibility issues, so there is no reason not to update.

jdegoes
jdegoes previously approved these changes Sep 28, 2018
View reviewed changes
@pshirshov
Copy link
Member Author

Ergh, scalajs?.. It's interesting why did it appear in 2.11 build.

org.scala-js#scalajs-compiler_2.12.7;0.6.24

Such a dependency shouldn't appear at all. This is interesting, I will investigate.

@pshirshov
Copy link
Member Author

Also I've noticed an irrelated problem

Exception in thread "specs2.user-3" java.lang.NoSuchMethodError: cats.effect.Effect.runAsync(Ljava/lang/Object;Lscala/Function1;)Lcats/effect/IO;
	at fs2.async.package$.fork(async.scala:138)
	at fs2.async.package$$anonfun$start$1.apply(async.scala:108)
	at fs2.async.package$$anonfun$start$1.apply(async.scala:107)
	at cats.effect.internals.IORunLoop$.liftedTree3$1(IORunLoop.scala:216)
	at cats.effect.internals.IORunLoop$.step(IORunLoop.scala:216)
	at cats.effect.IO.unsafeRunTimed(IO.scala:321)
	at cats.effect.IO.unsafeRunSync(IO.scala:240)
	at scalaz.zio.interop.ZioWithFs2Spec.fIsCats(Fs2ZioSpec.scala:24)
	at scalaz.zio.interop.ZioWithFs2Spec$$anonfun$is$1$$anonfun$apply$1$$anonfun$apply$2.apply(Fs2ZioSpec.scala:16)
	at scalaz.zio.interop.ZioWithFs2Spec$$anonfun$is$1$$anonfun$apply$1$$anonfun$apply$2.apply(Fs2ZioSpec.scala:16)
	at org.specs2.matcher.Expectable.value$lzycompute(Expectable.scala:21)
	at org.specs2.matcher.Expectable.value(Expectable.scala:21)
	at org.specs2.matcher.EqualityMatcher.apply(EqualityMatcher.scala:25)
	at org.specs2.matcher.Expectable.applyMatcher(Expectable.scala:51)
	at org.specs2.matcher.MustExpectable.must_$eq$eq$eq(MustExpectable.scala:20)
	at scalaz.zio.interop.ZioWithFs2Spec$$anonfun$simpleJoin$1.apply(Fs2ZioSpec.scala:21)
	at scalaz.zio.interop.ZioWithFs2Spec$$anonfun$simpleJoin$1.apply(Fs2ZioSpec.scala:21)
	at org.specs2.specification.AroundTimeout$$anon$1.result$lzycompute$1(ExamplesTimeout.scala:37)
	at

This doesn't break the build but seemt like there is a minor classpath issue after @Kaishh contribution.

@pshirshov pshirshov force-pushed the feature/scala-sbt-upd branch 2 times, most recently from 405404d to 4725123 Compare September 28, 2018 20:03
@pshirshov
Copy link
Member Author

@jdegoes : job done.

Please consider - 2.11 build cannot be run on JDK10 because of the compiler bugs.

Also there is an annoying scalafmt issue rejecting valid code:

[error] Error in scalaz-zio/interop-cats-laws/src/test/scala/scalaz/zio/interop/catzSpec.scala: <input>:59: error: identifier expected but _ found
[error] checkAllAsync("Effect[Task]", implicit _ => EffectTests[Task].effect[Int, Int, Int])
[error]

Will try to fix it.

@pshirshov
Copy link
Member Author

pshirshov commented Sep 28, 2018 •
edited
Loading

Okay, workarounded scalafmt issue, relevant link: scalameta/scalafmt#1292

Not sure if it is good enough though.

@pshirshov
Copy link
Member Author

@jdegoes: done

@NeQuissimus
Copy link
Member

Can you squash related commits? :)

@pshirshov
Copy link
Member Author

I may. Though I thought you use squash and commit instead of just merging. W8 a min.

@pshirshov
scala 2.12.7 and sbt 1.2.3
ee015cd 
scalajs 0.6.26

scala 2.12.7 warnings considered

scala 2.12.7 warnings considered

scala 2.12.7 warnings considered

scalafmt applied, scalac (or scalafmt) workaround

fs2 1.0.0-M5

scalafmt reapplied

fs2 compat

scalafmt reapplied
@pshirshov pshirshov force-pushed the feature/scala-sbt-upd branch from f81a92b to ee015cd Compare September 29, 2018 22:11
@pshirshov
Copy link
Member Author

Done. Why not to set squashing as default policy?

@NeQuissimus
Copy link
Member

Oh, nvm, I could have. I had meant to group into logical commits but it's OK :)

I guess the sbt commit would have been extremely trivial :D

@jdegoes
Copy link
Member

jdegoes commented Sep 30, 2018

@pshirshov Thanks, Paul!

@jdegoes jdegoes merged commit ab12b7f into zio:master Sep 30, 2018
@pshirshov pshirshov deleted the feature/scala-sbt-upd branch September 30, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdegoes jdegoes jdegoes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pshirshov @NeQuissimus @jdegoes