ZConduit #3079
Merged
ZConduit #3079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27209b9 to
98260a5
Compare
|
|
288b742 to
92d610f
Compare
|
@regiskuckaertz I force-pushed the branch to my rebase yesterday so please rebase your open branch on it 🙏🏻 |
374d28e to
2b8eceb
Compare
iravid
commented
Apr 25, 2020
| case (Some(Right(l)), Some(Left(r))) => Some(l.zipWith(r)(f)) | ||
| case (Some(Left(l)), Some(Right(r))) => Some(l.zipWith(r)(f)) | ||
| case _ => None | ||
| left.zipAllWith(right)(l => (Some(l), None), r => (None, Some(r)))((l, r) => (Some(l), Some(r))).collectWhile { |
There was a problem hiding this comment.
@adamgfraser Please double-check this
iravid
commented
Apr 25, 2020
| val value = f(self.value, that.value) | ||
| val shrink = self.shrink | ||
| .combine[R1, Nothing, State, Sample[R1, B], Sample[R1, C]](that.shrink)((false, false, None, None)) { | ||
| case ((leftDone, rightDone, s1, s2), left, right) => |
9cbd419 to
ba7d5c0
Compare
Co-authored-by: Regis Kuckaertz <[email protected]> Co-authored-by: Evgenii Kuznetcov <[email protected]>
ba7d5c0 to
a3dfc7c
Compare
b3a467e to
7676377
Compare
|
Will merge this after CI is green if no objections. @zio/core |
|
@iravid Great! |
This was referenced Apr 30, 2020
michalwarecki
added a commit
to michalwarecki/zio
that referenced
this pull request
Apr 30, 2020
michalwarecki
added a commit
to michalwarecki/zio
that referenced
this pull request
Apr 30, 2020
iravid
pushed a commit
that referenced
this pull request
Apr 30, 2020
* ZIO Streams - improved documentation. * Updated ZStream documentation based on #3079 change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2719
Resolves #2720
Resolves #3347
Resolves #3399
Resolves #3189