Port reject/rejectM to ZManaged #3109
Conversation
| * Fail with the returned value if the `PartialFunction` matches, otherwise | ||
| * continue with our held value. | ||
| */ | ||
| def reject[R1 <: R, E1 >: E](pf: PartialFunction[A, E1]): ZManaged[R1, E1, A] = |
There was a problem hiding this comment.
You can delete the R1 type parameter here since you aren't using it anywhere. The partial function doesn't use an environment so the environmental requirements of the new effect will be the same as those of the original effect.
There was a problem hiding this comment.
Looks like the same issue is present in the implementations for ZIO and ZSTM. You want to fix there as well?
There was a problem hiding this comment.
Yeah, I shouldn't have blindly copied that parameter 🤦♂️ .
Good catch.
WRT to ZIO and ZSTM, this might break explicitly annotated user calls, are we ok with it?
There was a problem hiding this comment.
No worries! That is why we do these reviews. Yes we are okay with breaking compatibility at this point. I highly doubt there is significant usage with annotations, users will be glad to not have to specify an extra type parameter if they do have to, and now is the time to make these changes before we release 1.0 and have to ensure binary compatibility. Good question though!
Ticks reject/rejectM in #2077