JS Promise interop #3163
Merged
JS Promise interop #3163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing ❤️ I looked into the code on Scala JS, the Do you have bandwidth to convert this using ZIO's own Promise? |
|
Thanks. Will do. |
|
@regiskuckaertz How about now, I think it's even more straight to the point. |
|
@regiskuckaertz Could you please take another look? Thanks. |
|
Sorry for the lack of feedback. Thanks again for doing this, there's one minor nit then it looks great to me 👍 |
Co-Authored-By: Regis Kuckaertz <[email protected]>
|
No problem, I committed your suggestion. |
regiskuckaertz
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2881.
In line with the Scala.js recommendations: https://www.scala-js.org/api/scalajs-library/1.0.1/scala/scalajs/js/Promise.html
@regiskuckaertz as original issue author.