Added fromIterator versions that capture exceptions. #3195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iravid
reviewed
Mar 23, 2020
Co-Authored-By: Itamar Ravid <[email protected]>
Co-Authored-By: Itamar Ravid <[email protected]>
|
I'll review it myself as well, I think there are some simplifications that could be made like |
|
I think the call to Stream#iterator is rightly suspended as who knows what throws and what doesn’t 🤷🏼♂️ |
sir-wabbit
commented
Mar 23, 2020
|
Okay, fixed one more minor problem in |
|
Needs a format and should be good to go! |
iravid
approved these changes
Mar 23, 2020
|
Awesome work. Thanks again @alexknvl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2334.