Prevent retry storms on ZSTM #3210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of ZSTM suffers from "retry storms." For example, short transactions can force long-running ones to retry.
To verify this behavior, I've set the following benchmark:
TRefcontaining a list of 10000 elementsRunning this benchmark on the current implementation produces the following result:
The solution to this problem is to count the number of retries, and obtain a global lock once this count breaches some predefined limit. Acquiring a global lock should allow a long-running transaction to complete. To avoid paying the high locking "price," the number of max retries should be chosen from
[10, 100]. Based on the results of my trial benchmarks, I've decided to set it to 10.With this change in place, the benchmark mentioned above produced the following result: