Implemented lens-like ZRef focusing on state components #3257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Ah funny I have been working on something similar. Will post my current version as well. |
|
@Odomontois @adamgfraser Great minds think alike. 😆 Glad to see this development finally happening. it was the main reason for the I'll let you two figure out how to merge these ideas and do a review when you're ready. |
|
Closed in favor of the hybrid #3258. @Odomontois Thanks for your work on this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for more general than
foldtransformer forZRefnamedfocusFoldwith lens-like interface.Such a transformer can focus mutable access on individual components of product types, such as case classes and collections.
Changes overview:
focusFold, which can analyze old read value during an update.ZRefnamedFocusedwhich has worse performance in general than previousDerived.Derivedrenamed toMappedand now extendsFocusedto reduce code repetition