Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Introduce ZTRef #3266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2020
Merged

Introduce ZTRef #3266

merged 1 commit into from
Apr 3, 2020

Conversation

@vasilmkd
Copy link
Contributor

@vasilmkd vasilmkd commented Apr 2, 2020 •
edited
Loading

adamgfraser
adamgfraser suggested changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just minor compatibility issues with Either#flatMap not being defined on early Scala versions. There is an EitherCompat trait you can use to resolve.

@vasilmkd
Copy link
Contributor Author

vasilmkd commented Apr 3, 2020

@adamgfraser Thanks, it's easy when there's a lot of great code lying around. Scala 2.11 peculiarities should be fixed now.

@vasilmkd vasilmkd requested a review from adamgfraser April 3, 2020 00:41
@adamgfraser adamgfraser merged commit 3c86e31 into zio:master Apr 3, 2020
@vasilmkd vasilmkd deleted the ztref branch April 3, 2020 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Give TRef the polymorphic treatment

2 participants

@vasilmkd @adamgfraser