Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Varargs support in accessible #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2020
Merged

Varargs support in accessible #3283

merged 1 commit into from
Apr 5, 2020

Conversation

@senia-psm
Copy link
Member

Support for varargs (def m(arg: Int*)) in accessible macro.

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2020 •
edited
Loading

CLA assistant check)
All committers have signed the CLA.

@senia-psm senia-psm force-pushed the feature/Varargs_support_in_accessible branch from 4aff1d3 to 91bc06a Compare April 4, 2020 18:13
@ioleo
Copy link
Member

ioleo commented Apr 4, 2020

Great addition, thank you! 🙏
Could you perhaps also add varargs support to @mockable macro?

Regarding the implementation, I don't think we have access to internal isRepeatedParamType, so I'm OK with copying.

@senia-psm
Copy link
Member Author

@ioleo it's in my nearest plans. Right before updating zio-intellij support for both. Though I'd prefer to do it in another PR.

@senia-psm
Copy link
Member Author

@ioleo see #3292 for varargs support in mockable.

@adamgfraser adamgfraser requested a review from ioleo April 5, 2020 15:03
ioleo
ioleo approved these changes Apr 5, 2020
View reviewed changes
Copy link
Member

@ioleo ioleo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Great job! Perhaps we should also add tests for curried varargs def curriedVarargs(a: Int, b: String*)(c: Long, d: Double*): IO[String, Int] (as you did with @mockable), but we can do that in another PR. Thank you!

@adamgfraser adamgfraser merged commit 9df0d8e into zio:master Apr 5, 2020
@senia-psm senia-psm deleted the feature/Varargs_support_in_accessible branch April 5, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ioleo ioleo ioleo approved these changes

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@senia-psm @CLAassistant @ioleo @adamgfraser