Fix ++(nonEmpty) on Chunk #3309
Conversation
|
@adamgfraser thanks for the review! changing it. Following #3241 (comment) it would work if we don't define : trait NonEmpty[A] {
def ++[A1 >: A](that: Chunk[A1]): NonEmptyChunk[A1]
} |
|
@ahoy-jon Yes. It looks like if we only define both |
|
I think we can get away with just defining the variant that takes a non-empty chunk in the implicit syntax class and leave everything else on the trait. |
|
|
||
| object Chunk { | ||
|
|
||
| implicit class ChunkOps[A](private val self: Chunk[A]) extends AnyVal { |
There was a problem hiding this comment.
Don't need the A1 type parameter here since A in ChunkOps is invariant.
There was a problem hiding this comment.
Not sure about that, it doesn't create compilation error in ZIO, but when with use subtyping, doesn't work.
trait A
trait B extends A
val x: Chunk[B] = Chunk.empty
//x: zio.Chunk[B] = Empty$()
x ++ (new A {})
<console>:28: error: overloaded method value ++ with alternatives:
(nonEmptyChunk: zio.NonEmptyChunk[B])zio.NonEmptyChunk[B] <and>
(chunk: zio.Chunk[B])zio.Chunk[B]
cannot be applied to (A)
x ++ (new A {})|
<feelings> I was actually fine with letting it go, and add a Thanks for the reviews. About |
following discussion #3241