Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve TMap's performance #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 12, 2020
Merged

Improve TMap's performance #3343

merged 8 commits into from
Apr 12, 2020

Conversation

@mijicd
Copy link
Member

@mijicd mijicd commented Apr 12, 2020

Follow-up of work in #3340

Summary

  • Removed tCapacity.
  • Implemented folds in terms of array's toList.
  • Updated ref directly instead of calling TArray.update (TMap.put).

Results

Before changes:

Benchmark                     (size)   Mode  Cnt       Score      Error  Units
TMapOpsBenchmarks.lookup           0  thrpt   15    4436.587 ±   10.183  ops/s
TMapOpsBenchmarks.lookup          10  thrpt   15    4368.201 ±   12.689  ops/s
TMapOpsBenchmarks.lookup         100  thrpt   15    4086.666 ±   15.626  ops/s
TMapOpsBenchmarks.lookup        1000  thrpt   15    4238.726 ±   13.847  ops/s
TMapOpsBenchmarks.lookup       10000  thrpt   15    4023.562 ±   13.877  ops/s
TMapOpsBenchmarks.lookup      100000  thrpt   15    4054.109 ±   11.264  ops/s
TMapOpsBenchmarks.removal          0  thrpt   15    2926.250 ±    8.003  ops/s
TMapOpsBenchmarks.removal         10  thrpt   15    2948.677 ±   14.846  ops/s
TMapOpsBenchmarks.removal        100  thrpt   15    2997.450 ±   11.158  ops/s
TMapOpsBenchmarks.removal       1000  thrpt   15    2931.569 ±   10.569  ops/s
TMapOpsBenchmarks.removal      10000  thrpt   15    2735.768 ±    9.069  ops/s
TMapOpsBenchmarks.removal     100000  thrpt   15    2799.613 ±   10.705  ops/s
TMapOpsBenchmarks.transform        0  thrpt   15  147626.711 ± 4480.114  ops/s
TMapOpsBenchmarks.transform       10  thrpt   15  117361.859 ± 2586.968  ops/s
TMapOpsBenchmarks.transform      100  thrpt   15   15410.151 ±  146.171  ops/s
TMapOpsBenchmarks.transform     1000  thrpt   15    1851.614 ±    9.558  ops/s
TMapOpsBenchmarks.transform    10000  thrpt   15      95.270 ±    0.856  ops/s
TMapOpsBenchmarks.transform   100000  thrpt   15       6.637 ±    0.119  ops/s
TMapOpsBenchmarks.transformM       0  thrpt   15  145586.842 ± 3118.637  ops/s
TMapOpsBenchmarks.transformM      10  thrpt   15   98668.752 ± 1333.670  ops/s
TMapOpsBenchmarks.transformM     100  thrpt   15   11833.112 ±   42.525  ops/s
TMapOpsBenchmarks.transformM    1000  thrpt   15    1232.090 ±    5.360  ops/s
TMapOpsBenchmarks.transformM   10000  thrpt   15      74.487 ±    1.760  ops/s
TMapOpsBenchmarks.transformM  100000  thrpt   15       5.181 ±    0.062  ops/s
TMapOpsBenchmarks.update           0  thrpt   15    2297.043 ±   11.710  ops/s
TMapOpsBenchmarks.update          10  thrpt   15    2285.341 ±   11.546  ops/s
TMapOpsBenchmarks.update         100  thrpt   15    2272.868 ±   10.996  ops/s
TMapOpsBenchmarks.update        1000  thrpt   15    2190.605 ±    8.394  ops/s
TMapOpsBenchmarks.update       10000  thrpt   15    2107.176 ±    7.606  ops/s
TMapOpsBenchmarks.update      100000  thrpt   15    2077.663 ±   10.517  ops/s

After changes:

Benchmark                     (size)   Mode  Cnt       Score      Error  Units
TMapOpsBenchmarks.lookup           0  thrpt   15    5072.946 ±   19.131  ops/s
TMapOpsBenchmarks.lookup          10  thrpt   15    5172.095 ±   20.090  ops/s
TMapOpsBenchmarks.lookup         100  thrpt   15    4838.867 ±   66.883  ops/s
TMapOpsBenchmarks.lookup        1000  thrpt   15    4963.935 ±    7.921  ops/s
TMapOpsBenchmarks.lookup       10000  thrpt   15    4845.461 ±   19.562  ops/s
TMapOpsBenchmarks.lookup      100000  thrpt   15    4592.221 ±   28.704  ops/s
TMapOpsBenchmarks.removal          0  thrpt   15    3566.088 ±   47.642  ops/s
TMapOpsBenchmarks.removal         10  thrpt   15    3588.899 ±   15.633  ops/s
TMapOpsBenchmarks.removal        100  thrpt   15    3510.764 ±   11.459  ops/s
TMapOpsBenchmarks.removal       1000  thrpt   15    3446.854 ±   13.075  ops/s
TMapOpsBenchmarks.removal      10000  thrpt   15    3431.371 ±    8.108  ops/s
TMapOpsBenchmarks.removal     100000  thrpt   15    3169.424 ±    6.962  ops/s
TMapOpsBenchmarks.transform        0  thrpt   15  148985.179 ± 3818.584  ops/s
TMapOpsBenchmarks.transform       10  thrpt   15  118974.349 ± 2685.904  ops/s
TMapOpsBenchmarks.transform      100  thrpt   15   15679.842 ±   42.883  ops/s
TMapOpsBenchmarks.transform     1000  thrpt   15    1839.234 ±   22.481  ops/s
TMapOpsBenchmarks.transform    10000  thrpt   15      96.660 ±    0.992  ops/s
TMapOpsBenchmarks.transform   100000  thrpt   15       7.093 ±    0.112  ops/s
TMapOpsBenchmarks.transformM       0  thrpt   15  144693.581 ± 4076.923  ops/s
TMapOpsBenchmarks.transformM      10  thrpt   15   97583.697 ± 1395.881  ops/s
TMapOpsBenchmarks.transformM     100  thrpt   15   11675.240 ±   85.219  ops/s
TMapOpsBenchmarks.transformM    1000  thrpt   15    1237.373 ±    3.750  ops/s
TMapOpsBenchmarks.transformM   10000  thrpt   15      74.736 ±    1.810  ops/s
TMapOpsBenchmarks.transformM  100000  thrpt   15       5.120 ±    0.080  ops/s
TMapOpsBenchmarks.update           0  thrpt   15    2839.403 ±   16.044  ops/s
TMapOpsBenchmarks.update          10  thrpt   15    2813.640 ±   10.368  ops/s
TMapOpsBenchmarks.update         100  thrpt   15    2775.875 ±   16.918  ops/s
TMapOpsBenchmarks.update        1000  thrpt   15    2664.176 ±    8.966  ops/s
TMapOpsBenchmarks.update       10000  thrpt   15    2618.346 ±   24.823  ops/s
TMapOpsBenchmarks.update      100000  thrpt   15    2507.069 ±    7.912  ops/s

jdegoes
jdegoes approved these changes Apr 12, 2020
View reviewed changes
Copy link
Member

@jdegoes jdegoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

@mijicd mijicd marked this pull request as ready for review April 12, 2020 21:48
@mijicd mijicd merged commit db82217 into zio:master Apr 12, 2020
@mijicd mijicd deleted the tmap-tuning branch April 12, 2020 21:48
@mijicd mijicd mentioned this pull request Apr 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdegoes jdegoes jdegoes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mijicd @jdegoes