Implement Fast Single Element Append for Chunk #3416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mijicd
reviewed
Apr 20, 2020
mijicd
reviewed
Apr 20, 2020
jdegoes
reviewed
Apr 20, 2020
jdegoes
reviewed
Apr 20, 2020
jdegoes
reviewed
Apr 20, 2020
jdegoes
reviewed
Apr 20, 2020
jdegoes
reviewed
Apr 20, 2020
jdegoes
requested changes
Apr 20, 2020
|
Benchmarks: [info] Benchmark (size) Mode Cnt Score Error Units
[info] ChunkAddBenchmarks.chunkAdd 10000 thrpt 25 2400.011 ± 128.596 ops/s
[info] ChunkAddBenchmarks.vectorAdd 10000 thrpt 25 1144.855 ± 32.112 ops/sSo more than twice as fast as |
jdegoes
previously approved these changes
Apr 25, 2020
|
@adamgfraser Good to merge when conflicts are fixed! Excellent work. |
|
@jdegoes This is ready to go. |
|
Shall we merge this before the next release? |
jdegoes
previously approved these changes
May 19, 2020
|
@adamgfraser Good to merge when conflicts are fixed! |
|
@jdegoes All set. |
jdegoes
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work to resolve #3371. I am also seeing dramatically faster performance than
Vector.