ZIO Test: Improve Management of Resources in Specs #3456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As t -> ♾, all |
jdegoes
previously approved these changes
Apr 26, 2020
|
|
|
@jdegoes I think this is ready to go. |
jdegoes
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now specs are effectual but because the effect is a
ZIOit has a fixed "scope" so when we doprovideLayerSharedwe need to create one effect that conceptually describes "running" the entire spec so that we can provide the layer to it. This creates issues because we have to prematurely decide what execution strategy to use and some combinators don't work afterprovideLayerSharedsince we have "already run" the spec by then.This PR changes specs to use a
ZManagedso we can expand the scope dynamically. This way we can just describe providing a resource to the spec and only at the time we execute the spec keep the scope open while we execute all the tests in the suite.