Redesign ZManaged around an embedded finalizer map #3510
Conversation
|
@ioleo I'm fairly confident that ZLayer is constructed correctly now, but the mocking specs are still not passing. Any chance you could look into this? |
| } | ||
| } | ||
| def flatMap[R1 <: R, E1 >: E, B](f: A => ZManaged[R1, E1, B]): ZManaged[R1, E1, B] = | ||
| ZManaged(self.zio.flatMap { case (_, a) => f(a).zio }) |
There was a problem hiding this comment.
Isn't the finaliser of the first effect important to keep here?
There was a problem hiding this comment.
That's a good question. The finalizers returned from the underlying ZIO are only used for early release.
I'm wondering if the correct thing to do is only allow the resulting ZIO to be released early, or should an early release of the resulting ZIO should also release the flatMapped ZIO.
Will think about this. Thank you for pointing this out!
There was a problem hiding this comment.
Ok, it's definitely right to compose the early release finalizers as well. Thanks @regiskuckaertz.
There was a problem hiding this comment.
Ha, I even did that without thinking for ZManaged.foreach.
c7c3d5e to
4961eea
Compare
| )(zero: B)(f: (B, A) => B): ZIO[R, E, B] = | ||
| Ref.make(zero) >>= { acc => | ||
| foreachParN_(n)(in) { | ||
| Predef.identity(_) >>= { a => acc.update(f(_, a)) } |
There was a problem hiding this comment.
Do you need the Predef.identity? 😮
There was a problem hiding this comment.
It’s shadowed by ZIO.identity 🤷🏼♂️
There was a problem hiding this comment.
Oh sorry I misread. This is silly. Will fix.
I admit to just copying the mergeAllPar implementation 😂
| release = finalizers.runAll | ||
| ) | ||
| } | ||
| def zipWithPar[R1 <: R, E1 >: E, A1, A2](that: ZManaged[R1, E1, A1])(f: (A, A1) => A2): ZManaged[R1, E1, A2] = |
|
This is amazing |
6547336 to
6f5d0b9
Compare
No description provided.