Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@luis3m
Copy link
Contributor

@luis3m luis3m commented May 4, 2020

As suggested on #3465, an implementation equivalent to Akka-streams' takeWithin.

@luis3m luis3m requested a review from iravid as a code owner May 4, 2020 16:21
@CLAassistant
Copy link

CLAassistant commented May 4, 2020

CLA assistant check
All committers have signed the CLA.

@luis3m
Copy link
Contributor Author

luis3m commented May 4, 2020

File needs to be formatted, will update in a few minutes

@luis3m luis3m force-pushed the interruptAfter branch from 956a912 to 7f165c4 Compare May 4, 2020 16:43
@luis3m
Copy link
Contributor Author

luis3m commented May 4, 2020

Done

@luis3m
Copy link
Contributor Author

luis3m commented May 5, 2020

All tests JVM and JS tests passing on top of these changes: #3424

iravid
iravid previously approved these changes May 7, 2020
Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Will merge after #3424.

@iravid iravid added the stream ZIO Stream label May 10, 2020
@luis3m
Copy link
Contributor Author

luis3m commented May 13, 2020

@iravid just rebased on top of #3424 and all tests are passing now

Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you @luis3m!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stream ZIO Stream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants