Fix ZStream.toInputStream handling of signed bytes #3546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added fix; modified test so that it will fail without the fix. - Description: The java.io.InputStream.read() method should return an Int. A value in the range 0 to 255 inclusive represents an unsigned byte value from the InputStream, while a value of -1 indicates that the end of the stream has been reached. Previously, calling .toInt on the raw Byte value was not performing the unsigned byte conversion required by read().
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java.io.InputStream.read()method should return anInt. A value in the range0to255inclusive represents an unsigned byte value from theInputStream, while a value of-1indicates that the end of the stream has been reached. Previously, calling.toInton the rawBytevalue was not performing the unsigned byte conversion required byread().Fixes issue #3545