Add ZIO.tupled #3565
Merged
Add ZIO.tupled #3565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
adamgfraser
previously approved these changes
May 10, 2020
There was a problem hiding this comment.
Looks great! Can you sign the CLA? Do you want to add the parallel variants as well?
Also wonder a little bit about the naming convention here. Perhaps mapN should go to ZipWithN, this should go to zipN, and the parallel variants could go to zipWithParN and zipParN?
|
@adamgfraser sure, I can add the parallel variants as well. Maybe open an issue about the naming conventions first? I can make those changes as well. |
|
@luis3m Sounds great! |
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested here #3564