Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add combinators collect, collectPar and collectParN #3568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 25, 2020
Merged

Add combinators collect, collectPar and collectParN #3568

merged 6 commits into from
May 25, 2020

Conversation

@ghidei
Copy link
Contributor

@ghidei ghidei commented May 10, 2020

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 10, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

adamgfraser
adamgfraser suggested changes May 10, 2020
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! See comments below. We could also implement this on ZManaged and ZSTM.

@ghidei
Review comments by Adam
f9dc307 
1. Rename methods from collectSome to collect
2. Add collectParN method
3. Fix so that aliases return the most specific type
4. Fix faulty implementation
@ghidei
Copy link
Contributor Author

ghidei commented May 10, 2020

By the way, is this PR related to what we're trying to do: #3442?

adamgfraser
adamgfraser suggested changes May 12, 2020
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Very minor comments. Did you want to do the ZManaged and ZSTM versions as well?

@ghidei
Copy link
Contributor Author

ghidei commented May 12, 2020

Great! I'll add it to ZManaged and ZSTM as soon as I can :)

@ghidei
Copy link
Contributor Author

ghidei commented May 20, 2020

@adamgfraser I've just added the combinators for ZManaged and ZSTM. I saw that there were some aliases for them, but they didn't really have any companion objects the same way the ZIO datatype has.

@ghidei
Copy link
Contributor Author

ghidei commented May 25, 2020

@adamgfraser Friendly reminder :)

adamgfraser
adamgfraser approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you and congratulations on your first contribution to ZIO!

@adamgfraser adamgfraser merged commit d835dea into zio:master May 25, 2020
@hmemcpy hmemcpy mentioned this pull request May 25, 2020
Closed
@ghidei ghidei changed the title WIP: Add combinators collectSome and collectSomePar WIP: Add combinators collect, collectPar and collectParN May 25, 2020
@ghidei ghidei changed the title WIP: Add combinators collect, collectPar and collectParN Add combinators collect, collectPar and collectParN May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ghidei @CLAassistant @adamgfraser