Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add someOrElse to ZSTM, ZIO and ZManaged #3560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 9, 2020
Merged

Add someOrElse to ZSTM, ZIO and ZManaged #3560

merged 4 commits into from
May 9, 2020

Conversation

@valenterry
Copy link
Contributor

@valenterry valenterry commented May 8, 2020 •
edited
Loading

This PR adds .someOrElse which behaves similar to .getOrElse of Option but in the context of ZSTM, ZIO or ZManaged

@CLAassistant
Copy link

CLAassistant commented May 8, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@valenterry valenterry changed the title Add .someOrElse Add ZSTM#someOrElse May 8, 2020
adamgfraser
adamgfraser suggested changes May 8, 2020
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Do you want to add to ZIO and ZManaged as well?

@valenterry valenterry changed the title Add ZSTM#someOrElse Add someOrElse to ZSTM, ZIO and ZManaged May 9, 2020
@valenterry valenterry requested a review from adamgfraser May 9, 2020 04:30
adamgfraser
adamgfraser approved these changes May 9, 2020
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Congratulations on your first contribution to ZIO!

@adamgfraser adamgfraser merged commit 5aee4be into zio:master May 9, 2020
@valenterry valenterry deleted the some-or-else branch May 9, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@valenterry @CLAassistant @adamgfraser