Add App ExitCode #3583
Merged
Add App ExitCode #3583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6fd3605 to
84e908a
Compare
jdegoes
reviewed
May 14, 2020
jdegoes
reviewed
May 14, 2020
|
/cc @adamgfraser for the scalafix part |
c5106da to
f9a1f8a
Compare
iravid
reviewed
May 15, 2020
| * Maps this effect to the default exit codes. | ||
| */ | ||
| final def exitCode: URIO[R, ExitCode] = | ||
| self.foldCauseM(cause => UIO(println(cause.prettyPrint)) as ExitCode.failure, _ => ZIO.succeedNow(ExitCode.success)) |
There was a problem hiding this comment.
Let’s use putStrLn instead of println here.
There was a problem hiding this comment.
@iravid I took this combinator from #2153, I suspect John suggested println to avoid adding a dependency on Console at the end of your program. OTOH, App uses ZEnv anyway so even if you write program.provideSomeLayer(ZEnv.live ++ customLayers).exitCode it won't crash as Console would be its only missing dependency which the default runtime will provide.
I will update in a few minutes (cc: @jdegoes)
jdegoes
approved these changes
May 19, 2020
|
@luis3m Thank you for this wonderful contribution! Much better than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2153 (cc @adamgfraser @jdegoes)