Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@luis3m
Copy link
Contributor

@luis3m luis3m commented May 16, 2020

No description provided.

@luis3m luis3m requested a review from iravid as a code owner May 16, 2020 00:49
@iravid iravid added enhancement New feature or request stream ZIO Stream labels May 18, 2020
@iravid
Copy link
Member

iravid commented May 18, 2020

Hey @luis3m, did you convert the tests to property checks as @simpadjo suggested? Not seeing those changes.

@luis3m
Copy link
Contributor Author

luis3m commented May 18, 2020

@iravid I somehow missed that part, will update in a few.

@luis3m
Copy link
Contributor Author

luis3m commented May 18, 2020

@iravid added the new properties

@simpadjo
Copy link
Contributor

@luis3m could you please make test input randomly generated?
Here is an example: https://github.com/zio/zio/blob/master/streams-tests/shared/src/test/scala/zio/stream/ZTransducerSpec.scala#L65

@luis3m
Copy link
Contributor Author

luis3m commented May 18, 2020

@simpadjo done

@simpadjo
Copy link
Contributor

Generating streams using ZStream.fromChunks gives better coverage (perhaps there should be an utility method for it). ZStream.fromIterable consists of a single chunk.

@luis3m
Copy link
Contributor Author

luis3m commented May 18, 2020

@simpadjo done (not sure what you mean by the utility method, something like streamOf?)

@simpadjo
Copy link
Contributor

Yes, something like (Gen[A], Gen[Int]) => Gen[Stream[A]]. Maybe Gen[Int] could be just hardcoded.
If you want to work on it, look at this issue as well: #3550

@luis3m
Copy link
Contributor Author

luis3m commented May 18, 2020

@simpadjo cool, I will probably work on this at some point this week (perhaps tonight but not sure)

Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @luis3m!

@iravid iravid merged commit 4dba67e into zio:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request stream ZIO Stream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants