optimize ZStream.toInputStream #3599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iravid
reviewed
May 17, 2020
|
|
||
| def testStream(assertion: java.io.InputStream => TestResult): ZIO[Any, Nothing, TestResult] = | ||
| ZIO | ||
| .foreach(List(1, 2, 5, 30)) { chunkSize => |
There was a problem hiding this comment.
Would it make sense to use a generator here?
There was a problem hiding this comment.
Added a generator and ended-up removing all my hand-written machinery.
Thanks!
| import zio.{ Chunk, Exit, FiberFailure, ZIO } | ||
|
|
||
| private[zio] class ZInputStream(chunks: Iterator[Chunk[Byte]]) extends java.io.InputStream { | ||
| private var current: Iterator[Byte] = Iterator.empty |
There was a problem hiding this comment.
Can we get rid of this and keep the current chunk and offsets in a var? This will box the bytes.
|
@iravid thanks for kind words! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3491